MML 4 Beta preparation #537

edwing-met · 2025-06-27T12:24:31Z

Goal

PR adding connectors to most CCGT and NPP components
A lot of parameters have also been given a default value inside the component so there is no need to attribute it in the model

Type of change

Bugfix
New feature
Refactoring change
Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

Breaking change (If yes, make sure to point it out in the changelog)
Non-Breaking change

Checklist

I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
I have performed a self-review of my own code
I have checked that all existing tests pass
I have checked that my work is compatible with OpenModelica
I have added/updated tests that prove my development works and does not break anything.
I have made corresponding changes or additions to the documentation (in Notion documentation)
I have added corresponding entries to the Changelog
I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

Signed-off-by: Nabil YOUSSEF <nabil.youssef@metroscope.tech>

Signed-off-by: Pierre-Elie Personnaz <pierre-elie.personnaz@metroscope.tech>

hadrienp-met

Merci ! Deux remarques principales :

Il y a peut être un truc qui m'échappe mais je comprends pas pourquoi on a besoin de définir des paramètres _constant ? Tel qu'ils sont utilisés, ce sont des variables d'initalisation mais on n'en a pas besoin por les paramètres
Il reste des composants à adapter comme l'ACC, je vais faire la liste
Idéalement il faudrait qu'on ai un modèle direct aussi de Metroscopia
Et il faudra adapter tous les tests
Bref pas mal de boulot qui doit mobiliser toute l'équipe !

hadrienp-met · 2025-06-27T12:36:38Z

MetroscopeModelingLibrary/FlueGases/Machines/AirCompressor.mo

+  parameter Real tau_constant = 15;
+  parameter Real eta_is_constant = 0.8;


Pourquoi on a ces paramètres ? Ils ne sont pas utilisés ensuite

hadrienp-met · 2025-06-27T12:40:07Z

MetroscopeModelingLibrary/FlueGases/Machines/GasTurbine.mo

@@ -12,9 +12,9 @@ model GasTurbine
  import MetroscopeModelingLibrary.Utilities.Units;
  import MetroscopeModelingLibrary.Utilities.Units.Inputs;

+  parameter Units.Yield eta_is_constant = 0.8;


Idem pourquoi ce paramètre ?

Suggested change

parameter Units.Yield eta_is_constant = 0.8;

hadrienp-met · 2025-06-27T12:41:02Z

...gLibrary/MetroscopeModelingLibrary.Examples.CCGT.MetroscopiaCCGT.MetroscopiaCCGT_reverse.mof

A supprimer

hadrienp-met · 2025-06-27T13:11:15Z

MetroscopeModelingLibrary/FlueGases/Machines/GasTurbine.mo

@@ -26,6 +26,13 @@ model GasTurbine
  Units.Percentage eta_is_decrease(min = 0, max=100) "percentage decrease of eta_is";

  Power.Connectors.Outlet C_W_shaft annotation (Placement(transformation(extent={{90,90},{110,110}}), iconTransformation(extent={{90,90},{110,110}})));
+  Utilities.Interfaces.GenericReal eta_is(start=eta_is_constant) annotation (Placement(transformation(


On a un besoin d'initialiser les eta is ? ça me semble pas utile

hadrienp-met · 2025-06-27T13:13:43Z

MetroscopeModelingLibrary/Partial/Pipes/ControlValve.mo

@@ -5,7 +5,7 @@ partial model ControlValve
  import MetroscopeModelingLibrary.Utilities.Units.Inputs;
  import MetroscopeModelingLibrary.Utilities.Constants;

-  Inputs.InputCv Cv_max(start=1e4) "Maximum CV";
+  parameter Units.Cv Cv_max_constant = 1e4 "Maximum CV";


Idem pourquoi le constant ?

hadrienp-met · 2025-06-27T13:14:01Z

MetroscopeModelingLibrary/Partial/Pipes/HeightVariationPipe.mo

-  parameter Boolean faulty = false;
-  Units.Percentage fouling; // Fouling coefficient
-
+  parameter Units.Height delta_z_constant = 10;


hadrienp-met · 2025-06-27T13:14:18Z

MetroscopeModelingLibrary/Partial/Pipes/SlideValve.mo


  parameter Boolean faulty = false;
  Units.Percentage closed_valve; // Valve not fully opened

+  parameter Real Cv_constant = 1e4;


hadrienp-met · 2025-07-03T11:47:30Z

MetroscopeModelingLibrary/Examples/CCGT/MetroscopiaCCGT/MetroscopiaCCGT_direct.mo

 equation
+  T_source_air = 24 + time*10;


à supprimer

hadrienp-met · 2025-07-03T11:48:46Z

MetroscopeModelingLibrary/Examples/Nuclear/MetroscopiaNPP/MetroscopiaNPP_reverse_old.mo

Bien de garder cette version dans la librairie

hadrienp-met · 2025-07-03T11:50:45Z

MetroscopeModelingLibrary/MultiFluid/Machines/CombustionChamber.mo

+  parameter Units.FrictionCoefficient Kfr_constant = 0;
+  parameter Real eta_constant=0.99457; // The value given is found in performance document of GE


Supprimer les paramètres constants

hadrienp-met · 2025-07-03T12:00:08Z

MetroscopeModelingLibrary/Partial/Pipes/ControlValve.mo

@@ -5,7 +5,7 @@ partial model ControlValve
  import MetroscopeModelingLibrary.Utilities.Units.Inputs;
  import MetroscopeModelingLibrary.Utilities.Constants;

-  Inputs.InputCv Cv_max(start=1e4) "Maximum CV";
+  parameter Units.Cv Cv_max_constant = 1e4 "Maximum CV";


à supprimer

hadrienp-met · 2025-07-03T12:00:53Z

MetroscopeModelingLibrary/Partial/Pipes/SlideValve.mo


  parameter Boolean faulty = false;
  Units.Percentage closed_valve; // Valve not fully opened

+  parameter Real Cv_constant = 1e4;


à supprimer

hadrienp-met · 2025-07-03T12:05:43Z

MetroscopeModelingLibrary/Tests/Multifluid/Machines/CombustionChamberwithRefMoistAir_testLHV.mo

à voir si on garde ce test

hadrienp-met · 2025-07-03T12:07:30Z

MetroscopeModelingLibrary/Utilities/Functions/ListInputsOutputs.mo

@nabily-met @edwing-met vous savez pourquoi on a cette fonction ?

* ACC in MML4 * ACC in MML4

* commit * enlever inutile * chromatograph * remove fuel source test

* adapted reactor and LiqLiqHX for mml4 * also added british units to the units choices of control sensors * Update MetroscopeModelingLibrary/WaterSteam/HeatExchangers/LiqLiqHX.mo Co-authored-by: Hadrien <113358529+hadrienp-met@users.noreply.github.com> * Update MetroscopeModelingLibrary/WaterSteam/HeatExchangers/LiqLiqHX.mo Co-authored-by: Hadrien <113358529+hadrienp-met@users.noreply.github.com> --------- Co-authored-by: Hadrien <113358529+hadrienp-met@users.noreply.github.com>

* commit * enlever inutile * chromatograph * remove fuel source test * Add BC, input for calibration and observables * Correct connector size --------- Co-authored-by: eguez <edwin.guez@metroscope.tech> Co-authored-by: edwing-met <132678195+edwing-met@users.noreply.github.com>

nabily-met and others added 16 commits March 14, 2025 14:08

add connectors

c722ae9

Signed-off-by: Nabil YOUSSEF <nabil.youssef@metroscope.tech>

Improved icons

4ce956e

Signed-off-by: Nabil YOUSSEF <nabil.youssef@metroscope.tech>

Added function to list inputs and outputs

6c6bee6

Signed-off-by: Nabil YOUSSEF <nabil.youssef@metroscope.tech>

imrpove demo

224b197

Signed-off-by: Nabil YOUSSEF <nabil.youssef@metroscope.tech>

little adaptations, no sensor name, error if no unit

6379caf

Signed-off-by: Pierre-Elie Personnaz <pierre-elie.personnaz@metroscope.tech>

Merge branch 'main' into NY_TestConnectors

e59ae80

added many connectors

baa297f

Signed-off-by: Pierre-Elie Personnaz <pierre-elie.personnaz@metroscope.tech>

finalized metroscopia CCGT

e229b3c

Signed-off-by: Pierre-Elie Personnaz <pierre-elie.personnaz@metroscope.tech>

moitie

aa9da0e

fix reverse ccgt

f6e1953

Signed-off-by: Pierre-Elie Personnaz <pierre-elie.personnaz@metroscope.tech>

stash

7afb326

added expression

7cb5e68

Signed-off-by: Pierre-Elie Personnaz <pierre-elie.personnaz@metroscope.tech>

Metroscopia almostfinshed

8883472

icons and NPP done

41f95b1

test CCGT et start values

e42b55e

CCGT et start values

49896dd

edwing-met changed the title ~~MML4~~ MML4 draft Jun 27, 2025

edwing-met added the ✨enhancement New feature or request label Jun 27, 2025

hadrienp-met requested changes Jun 27, 2025

View reviewed changes

hadrienp-met requested changes Jul 3, 2025

View reviewed changes

hadrienp-met changed the title ~~MML4 draft~~ MML 4 Beta preparation Jul 7, 2025

hadrienp-met and others added 7 commits July 7, 2025 17:48

ACC in MML4 (#538)

cf75ac4

* ACC in MML4 * ACC in MML4

Add fuel composition on fuel source (#553)

012f6bb

* commit * enlever inutile * chromatograph * remove fuel source test

fuel heater + moist air pressure fix

1d6256c

fuel heater fix

869a975

clarify start value allocation in base sensors (#557)

8d75979

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MML 4 Beta preparation #537

MML 4 Beta preparation #537

Uh oh!

edwing-met commented Jun 27, 2025 •

edited

Loading

Uh oh!

hadrienp-met left a comment

Uh oh!

hadrienp-met Jun 27, 2025

Uh oh!

hadrienp-met Jun 27, 2025

Uh oh!

hadrienp-met Jun 27, 2025

Uh oh!

hadrienp-met Jun 27, 2025

Uh oh!

hadrienp-met Jun 27, 2025

Uh oh!

hadrienp-met Jun 27, 2025

Uh oh!

hadrienp-met Jun 27, 2025

Uh oh!

hadrienp-met Jul 3, 2025

Uh oh!

hadrienp-met Jul 3, 2025

Uh oh!

hadrienp-met Jul 3, 2025

Uh oh!

hadrienp-met Jul 3, 2025

Uh oh!

hadrienp-met Jul 3, 2025

Uh oh!

hadrienp-met Jul 3, 2025

Uh oh!

hadrienp-met Jul 3, 2025

Uh oh!

Uh oh!

		parameter Real tau_constant = 15;
		parameter Real eta_is_constant = 0.8;

		parameter Units.FrictionCoefficient Kfr_constant = 0;
		parameter Real eta_constant=0.99457; // The value given is found in performance document of GE

MML 4 Beta preparation #537

Are you sure you want to change the base?

MML 4 Beta preparation #537

Uh oh!

Conversation

edwing-met commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Type of change

Checklist

Uh oh!

hadrienp-met left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

edwing-met commented Jun 27, 2025 •

edited

Loading