Skip to content

json encoder #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

json encoder #523

wants to merge 14 commits into from

Conversation

idoshr
Copy link
Contributor

@idoshr idoshr commented May 13, 2023

Fix issue while try to inherit from MongoEngineJSONEncoder
and for bonus add doc of how add encoder hope it will be helpful

Copy link
Collaborator

@insspb insspb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idoshr thank you for interest to this project.

I reviewed changes, being out of mongo right now. Please fix mentioned errors and I will recheck again.

@@ -78,7 +78,7 @@ def default(obj):
(BaseDocument, QuerySet, CommandCursor, DBRef, ObjectId),
):
return _convert_mongo_objects(obj)
return super().default(obj)
return superclass.default(obj)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? Where it from?

@idoshr
Copy link
Contributor Author

idoshr commented May 29, 2023

@insspb
What is your opinion on adding this default encoder
image

@EvanBldy
Copy link

Hi that's cool ! Thanks
Will you do a new release on pypi after that ?

@idoshr
Copy link
Contributor Author

idoshr commented Jun 16, 2023

This pull request spliced to 3 separated PRs
#526
#527
#528

@idoshr idoshr closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants