(GitHub code show whitespace) show all whitespaces

[jerone]

I tried GitHub code show whitespace today, and found that it only shows leading and trailing spaces & tabs. There is another script that does show the inline whitespaces, and I was wondering if you can implement this too.

[Mottie]

Hi @jerone!

That sounds like a good idea, I'll take a look!

[jerone]

@Mottie Saw you commit, all inline whitespaces work perfectly now. 🎉

I do however see an extra space character before every line now. For example jerone/UserScripts@0c1e262, the first userscript block in GitHub_Commit_Compare.user.js is not prefixed with a space in the code, still I see the space character.

Hope you can reproduce and find a solution.

[Mottie]

Hmm, the space you're reporting, I think, is due to the replacement of the "+" (or "-") in the diff. So the script that is replacing that symbol is the culprit; it's the github-remove-diff-signs.user.js script, if you're using it.

I do however see an issue in the readme file from that same commit - it looks like the space inside the span is being removed and the carriage returns are misaligned. I'll try to work on this later today.

[jerone]

@Mottie commented on Oct 2, 2017, 2:56 PM GMT+2:

Hmm, the space you're reporting, I think, is due to the replacement of the "+" (or "-") in the diff. So the script that is replacing that symbol is the culprit; it's the github-remove-diff-signs.user.js script, if you're using it.

You are right, I'm using that script. Maybe you can use a different whitespace character for that...

I do however see an issue in the readme file from that same commit - it looks like the space inside the span is being removed and the carriage returns are misaligned. I'll try to work on this later today.

Just noticed it too. It's not showing any whitespace character.

[Mottie]

Maybe you can use a different whitespace character for that...

I tried that, but I think it's best to completely remove the "+", "-" or first space because the whole reason we're doing it is to make it easier to copy/paste the code. The main issue then becomes removing the leading space in the expanded code section. I'll leave the detection and processing of the expanded section for a later version.

It's not showing any whitespace character.

It's the weirdest thing ever... I had to switch all the spans to use display: inline to get them to show, then I found that only the diffs for markdown and non-extension files (e.g. LICENSE) were effected by a misalignment of the placeholder symbols.

I ended up adding a work-around to adjust the specific diff files and then removing all tab-size adjustment code since I couldn't set a width with display: inline. It should all be working smoothly now.

[jerone]

It should all be working smoothly now.

It works great now! Thanks for fixing so fast.

[Mottie]

Derp, all I needed to do was to add css to hide the first whitespace element added by the userscript.