Skip to content

Support additional_instructions #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2025
Merged

Support additional_instructions #302

merged 4 commits into from
May 30, 2025

Conversation

gfreeman-nvidia
Copy link
Contributor

@gfreeman-nvidia gfreeman-nvidia commented May 19, 2025 •
edited
Loading

Description

React agent supports additional_instructions configuration option.
Add test cases for custom system prompt and adding additional_instructions.

Closes #301

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels May 22, 2025
@dagardner-nv
Copy link
Contributor

/ok to test 4beb14a

@dagardner-nv dagardner-nv mentioned this pull request May 30, 2025
Closed
@dagardner-nv dagardner-nv self-assigned this May 30, 2025
dagardner-nv
dagardner-nv reviewed May 30, 2025
View reviewed changes
@gfreeman-nvidia gfreeman-nvidia force-pushed the support_additional_instructions branch 2 times, most recently from 8d9a4b9 to f3c466f Compare May 30, 2025 22:25
@gfreeman-nvidia
Support additional_instructions. Add helper method for prompt creatio…
82ebfda 
…n. Add test cases for prompt configuration

Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
@gfreeman-nvidia
clean up print in test
56b23a9 
Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
@gfreeman-nvidia
move create_react_agent_prompt to agent.py to make register.py callab…
decf678 
…le without langchain. update imports.

Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
@gfreeman-nvidia
revert change in submodule
ea49767 
Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
@gfreeman-nvidia gfreeman-nvidia force-pushed the support_additional_instructions branch from f3c466f to ea49767 Compare May 30, 2025 22:31
@mdemoret-nv
Copy link
Collaborator

/ok to test ea49767

@dagardner-nv dagardner-nv self-requested a review May 30, 2025 23:54
@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 9d0577a into NVIDIA:develop May 30, 2025
12 checks passed
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@gfreeman-nvidia @ericevans-nv
Support additional_instructions (NVIDIA#302)
cdaa291 
React agent supports additional_instructions configuration option.
Add test cases for custom system prompt and adding additional_instructions.

Closes NVIDIA#301

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - https://github.com/gfreeman-nvidia

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#302
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@gfreeman-nvidia @ericevans-nv
Support additional_instructions (NVIDIA#302)
1acc903 
React agent supports additional_instructions configuration option.
Add test cases for custom system prompt and adding additional_instructions.

Closes NVIDIA#301

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - https://github.com/gfreeman-nvidia

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#302
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@gfreeman-nvidia @ericevans-nv
Support additional_instructions (NVIDIA#302)
4769940 
React agent supports additional_instructions configuration option.
Add test cases for custom system prompt and adding additional_instructions.

Closes NVIDIA#301

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - https://github.com/gfreeman-nvidia

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#302
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@gfreeman-nvidia
Support additional_instructions (NVIDIA#302)
9eebf07 
React agent supports additional_instructions configuration option.  
Add test cases for custom system prompt and adding additional_instructions.




Closes NVIDIA#301

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - https://github.com/gfreeman-nvidia

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#302
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@gfreeman-nvidia
Support additional_instructions (NVIDIA#302)
bd25e34 
React agent supports additional_instructions configuration option.  
Add test cases for custom system prompt and adding additional_instructions.




Closes NVIDIA#301

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - https://github.com/gfreeman-nvidia

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: NVIDIA#302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: React agent does not use additional_instructions input
3 participants
@gfreeman-nvidia @dagardner-nv @mdemoret-nv