Fixes Function and LambdaFunction classes to push active function instance names #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns with instance names. Signed-off-by: Matthew Penn <mpenn@nvidia.com>
yczhang-nv
approved these changes
Jun 16, 2025
|
/ok to test |
|
/merge |
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
…tance names (NVIDIA#374) Closes NVIDIA#364 This PR resolves an issue with how function names are set when invoking the `AIQContext.push_active_function` from the `Function` and `LambdaFunction` classes. Now, `instance_name` is passed into the `LambdaFunction.from_info` factory method and is an argument in class instance construction. This change removes ambiguity when working with `IntermediateStep` objects and exported traces when the same function is configured >1 times in the configuration object. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Matthew Penn (https://github.com/mpenn) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#374
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
…tance names (NVIDIA#374) Closes NVIDIA#364 This PR resolves an issue with how function names are set when invoking the `AIQContext.push_active_function` from the `Function` and `LambdaFunction` classes. Now, `instance_name` is passed into the `LambdaFunction.from_info` factory method and is an argument in class instance construction. This change removes ambiguity when working with `IntermediateStep` objects and exported traces when the same function is configured >1 times in the configuration object. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Matthew Penn (https://github.com/mpenn) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #364
This PR resolves an issue with how function names are set when invoking the
AIQContext.push_active_functionfrom theFunctionandLambdaFunctionclasses. Now,instance_nameis passed into theLambdaFunction.from_infofactory method and is an argument in class instance construction. This change removes ambiguity when working withIntermediateStepobjects and exported traces when the same function is configured >1 times in the configuration object.By Submitting this PR I confirm: