Upgrade tijsverkoyen/css-to-inline-styles to 2.0 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some problem with serialisation on HHVM which could be fixed soon. This seems to be affecting only the tests, not the actual code in the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would qualify as a breaking change, because we allow to pass an instance of the converter.
The API of the converter has changed.
While we can rely on users requiring the specific version of the converter library and Composer doing its job it's rare that people would require the correct version of sub-dependencies.
I would recommend people using the underlying converter library to make a conscious choice of upgrading.
Resolves #12.