-
Notifications
You must be signed in to change notification settings - Fork 2
Optional dependencies #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 9420343705Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
3c6fc47
to
63c2fbb
Compare
Pull Request Test Coverage Report for Build 9421738334Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9421737879Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ipywidgets cannot be optional, because they are being used by the interactive calibration tools. Testing should also be done on the minimal requirements, to make sure this works, I would say.
As for the opencv question: This is a dependency via symmetrize. It was introduced here to limit the version because of a bug at some point: 1f3b025 |
Pull Request Test Coverage Report for Build 9431469140Details
💛 - Coveralls |
Update dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added a small update to the release documentation.
Pull Request Test Coverage Report for Build 9496579533Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9496579760Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I noticed that while some notebook dependencies were tagged optional, others weren't. And the pip users wouldn't be installing the optional ones without doing
pip install sed-processor[notebook]
So I have made all notebook dependencies optional. User can install with
pip install sed-processor[all]
or
pip install sed-processor[notebook]
currently, since there are no other optional dependencies groups.
This is reflected in the README now.