Skip to content

Conversation

zain-sohail
Copy link
Member

I noticed that while some notebook dependencies were tagged optional, others weren't. And the pip users wouldn't be installing the optional ones without doing
pip install sed-processor[notebook]

So I have made all notebook dependencies optional. User can install with
pip install sed-processor[all]
or
pip install sed-processor[notebook]
currently, since there are no other optional dependencies groups.

This is reflected in the README now.

@zain-sohail zain-sohail closed this Jun 7, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9420343705

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.755%

Totals Coverage Status
Change from base Build 9369127364: 0.05%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls

@zain-sohail zain-sohail reopened this Jun 7, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9421738334

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.755%

Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9421737879

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.755%

Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls

Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ipywidgets cannot be optional, because they are being used by the interactive calibration tools. Testing should also be done on the minimal requirements, to make sure this works, I would say.

@rettigl
Copy link
Member

rettigl commented Jun 8, 2024

As for the opencv question: This is a dependency via symmetrize. It was introduced here to limit the version because of a bug at some point: 1f3b025
We can try removing it now again.

@coveralls
Copy link
Collaborator

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431469140

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.755%

Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls

Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a small update to the release documentation.

@coveralls
Copy link
Collaborator

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9496579533

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.755%

Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9496579760

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.755%

Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls

@zain-sohail zain-sohail merged commit cc382cf into main Jun 13, 2024
@zain-sohail zain-sohail deleted the move-dependencies branch June 13, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants