Skip to content

Py39 update annotations #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 22, 2024
Merged

Py39 update annotations #428

merged 6 commits into from
Jun 22, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jun 21, 2024

This updates type annotations to python 3.9 style

@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9620094215

Details

  • 144 of 144 (100.0%) changed or added relevant lines in 41 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 91.857%
Files with Coverage Reduction New Missed Lines %
sed/core/metadata.py 1 93.22%
Totals Coverage Status
Change from base Build 9618859347: -0.02%
Covered Lines: 6430
Relevant Lines: 7000
💛 - Coveralls

@zain-sohail
Copy link
Member

I wouldn't merge this till #427 is fully ready. Otherwise it will be hard to review.

@rettigl rettigl merged commit 59d76b8 into python-upgrade-39 Jun 22, 2024
@rettigl rettigl deleted the py39_update_annotations branch June 22, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rettigl @coveralls @zain-sohail