Skip to content

using importlib to get package version #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2024
Merged

using importlib to get package version #429

merged 3 commits into from
Jun 24, 2024

Conversation

zain-sohail
Copy link
Member

Currently after importing sed, typing sed.__version__ gives 0.1.0 because it's been hardcoded. This PR should solve the issue.

@coveralls
Copy link
Collaborator

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9626743539

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 91.888%
Files with Coverage Reduction New Missed Lines %
sed/calibrator/momentum.py 5 86.96%
Totals Coverage Status
Change from base Build 9572471667: -0.07%
Covered Lines: 6457
Relevant Lines: 7027
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9626743239

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 91.888%
Files with Coverage Reduction New Missed Lines %
sed/calibrator/momentum.py 5 86.96%
Totals Coverage Status
Change from base Build 9572471667: -0.07%
Covered Lines: 6457
Relevant Lines: 7027
💛 - Coveralls

@zain-sohail zain-sohail mentioned this pull request Jun 22, 2024
Open
rettigl
rettigl approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9648917236

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 91.888%
Files with Coverage Reduction New Missed Lines %
sed/calibrator/momentum.py 5 86.96%
Totals Coverage Status
Change from base Build 9572471667: -0.07%
Covered Lines: 6457
Relevant Lines: 7027
💛 - Coveralls

@zain-sohail zain-sohail merged commit 610ad8b into main Jun 24, 2024
@zain-sohail zain-sohail deleted the proper-versioning branch June 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rettigl rettigl rettigl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zain-sohail @coveralls @rettigl