Skip to content

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Nov 12, 2024

Update jupyterlab and corresponding widgets to work with jupyterlab >4 (has been updated on maxwell).

@rettigl rettigl changed the base branch from main to v1_feature_branch November 12, 2024 23:00
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11807179197

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 92.631%

Files with Coverage Reduction New Missed Lines %
src/sed/binning/numba_bin.py 2 87.5%
Totals Coverage Status
Change from base Build 11806926309: -0.03%
Covered Lines: 7555
Relevant Lines: 8156

💛 - Coveralls

@rettigl rettigl requested a review from zain-sohail November 13, 2024 11:01
@rettigl
Copy link
Member Author

rettigl commented Nov 13, 2024

@zain-sohail The jupyter lab version on Maxwell has been updated to 4.1.x in the py3.11 environment on maxwell. This upgrades the widget packages to be compatible to that.

@zain-sohail
Copy link
Member

Update jupyterlab and corresponding widgets to work with jupyterlab >4 (has been updated on maxwell).

The widgets seem to work for me in the current v1 branch. Could you elaborate the updates?

@rettigl
Copy link
Member Author

rettigl commented Nov 16, 2024

Update jupyterlab and corresponding widgets to work with jupyterlab >4 (has been updated on maxwell).

The widgets seem to work for me in the current v1 branch. Could you elaborate the updates?

For Testing, make sure you are using the kernel from the right environment (py311 vs. py39)
This is what I get with the package config of v1, if I start the Python 3.11 setting:
grafik
grafik
grafik
After installing the package config from this branch, it works:
grafik

Similarly, if I start with python 3.9 setting:
grafik
grafik
It does not work with this branch:
grafik
But does with the v1 branch:
grafik

@zain-sohail
Copy link
Member

For Testing, make sure you are using the kernel from the right environment (py311 vs. py39) This is what I get with the package config of v1, if I start the Python 3.11 setting:

So indeed I loaded this env but for creating a poetry or pip env, did you use python 3.9 or 3.11? Because currently I load jupyterlab 4 with this python 3.11 option at start screen (but using the older python 3.9 for my sed env), everything works from v1:

image
image

@rettigl
Copy link
Member Author

rettigl commented Nov 16, 2024

For Testing, make sure you are using the kernel from the right environment (py311 vs. py39) This is what I get with the package config of v1, if I start the Python 3.11 setting:

So indeed I loaded this env but for creating a poetry or pip env, did you use python 3.9 or 3.11? Because currently I load jupyterlab 4 with this python 3.11 option at start screen (but using the older python 3.9 for my sed env), everything works from v1:

image image

I used the python version that is active per default with the setting. The problem is not with plotting, this works in both cases, it is about the widgets, I. E. The progress bars or control inputs for the Gui panels

@zain-sohail
Copy link
Member

I used the python version that is active per default with the setting. The problem is not with plotting, this works in both cases, it is about the widgets, I. E. The progress bars or control inputs for the Gui panels

Widgets such as progress bars also work fine.
image
I also tested this with a new envusing python 3.11 and the widgets work fine.

We can still update this if it's causing problems on your end. Does this branch also work with jupyter <4 (or the python 3.9 jupyter that maxwell offers)?

@rettigl
Copy link
Member Author

rettigl commented Nov 16, 2024

I also tested this with a new envusing python 3.11 and the widgets work fine.

I find this different behavior quite strange, but if it also works for you with the upgraded packages, I suggest to merge this.

Does this branch also work with jupyter <4 (or the python 3.9 jupyter that maxwell offers)?

See my examples above. For me, this branch works for jupyterlab > 4, while the v1 branch does not, and vice versa.

As the only reason I limited jupyterlab was the installation on maxwell, and there is now a newer version there, I don't see a reason anymore to limit it.

@rettigl rettigl merged commit 8f4b6bf into v1_feature_branch Nov 21, 2024
6 checks passed
@rettigl rettigl deleted the update_jupyter branch November 21, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants