-
-
Notifications
You must be signed in to change notification settings - Fork 518
[GSoC] Feature Request : Plugin Architecture (Features as Plugins) #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Feature Request : Plugin Architecture (Features as Plugins) #1340
Conversation
gives sample demo for `TalawaPluginProvider `
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
@JamaicanFriedChicken |
Codecov Report
@@ Coverage Diff @@
## develop #1340 +/- ##
===========================================
- Coverage 71.10% 70.89% -0.22%
===========================================
Files 127 131 +4
Lines 6379 6589 +210
===========================================
+ Hits 4536 4671 +135
- Misses 1843 1918 +75
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a couple more tests to get the code coverage higher such that it will pass all the criteria to be merged. Other than that it looks good! Good job!
Sir I have added some tests now 👍🏻 |
@palisadoes Please provide the workflow approval for this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This Pull Request is associated with Google Summer of Code 2022 Project link
What kind of change does this PR introduce?
Feature Request #1339
Issue Number:
Fixes #1339
Did you add tests for your changes?
Yes
Snapshots/Videos:
Not Needed
If relevant, did you update the documentation?
Not required
Summary
Plugin are features which can toggled to enable or disable by the talawa-admin application with proper authorization
This project has two parts:
The design and development of the plugin architecture
Create
TalwaPluginProvider
widget in flutter which can control visibility of the UI according to the visibility property set by the admin. It can look like thisfetch_plugin_list
function which will load the new list of plugin after the app is restartedDoes this PR introduce a breaking change?
No
Other information
Not Required.
Have you read the contributing guide?
Yes