Even less cheating in class.c
#23544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bram-perl
reviewed
Aug 7, 2025
leonerd
force-pushed
the
even-less-cheating-in-class.c
branch
2 times, most recently
from
c4b4d29 to
13afe17
Compare
tonycoz
approved these changes
Aug 10, 2025
This simplifies potential callsites from other locations, avoiding their need to create the special weird OP_ARGELEM fragments. Additionally this decouples the knowledge that these operations are run on OP_ARGELEM ops in the first place, allowing for a future version that operates differently.
Previously, the op fragments created here were woven into the signature handling part of the final optree and had to contain a few extra fields related to signature argument handling. Since `subsignature_finish()` now creates the entire optree itself, the ops created by the tokenizer are only used for their side-effect of containing the pad offset in `op_targ`. As such, they no longer need to be specially sized OP_ARGELEM and can be regular OP_PADANYs.
This removes a bunch of special-case logic from `class.c`, making it behave much more similar to regular user-defined methods in the way it creates the signature-handling part of its optree.
leonerd
force-pushed
the
even-less-cheating-in-class.c
branch
from
13afe17 to
0bcda08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of ec78f9b, this sequence of commits further removes special-case code in
class.cby getting the subsignature API to build the signature ops for generated accessor methods, rather than performing custom work itself.Part of this change also involves simplifying the API for
subsignature_append_positional()andsubsignature_append_slurpy(), which also simplifies code intoke.cas a side benefit.All of these changes are in support of better signature generation code that ultimately helps with the
faster-signaturesbranch and named parameter support.