Skip to content

Move fixed tests from t/run/todo to final .t files #23545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion t/re/pat.t
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ skip_all_without_unicode_tables();
my $has_locales = locales_enabled('LC_CTYPE');
my $utf8_locale = find_utf8_ctype_locale();

plan tests => 1295; # Update this when adding/deleting tests.
plan tests => 1296; # Update this when adding/deleting tests.

run_tests() unless caller;

Expand Down Expand Up @@ -2643,6 +2643,12 @@ local $SIG{__WARN__} = sub { die; };
eval "qr/()x{/;" for 1..10;
PROG
}

{ # GH 16894 Fixed by acababb42be12ff2986b73c1bfa963b70bb5d54e
"abab" =~ /(?:[^b]*(?=(b)|(a))ab)*/;
is($1, undef, "GH #16894");
}

} # End of sub run_tests

1;
Expand Down
10 changes: 10 additions & 0 deletions t/re/pat_advanced.t
Original file line number Diff line number Diff line change
Expand Up @@ -2713,6 +2713,16 @@ EOF_DEBUG_OUT
$x =~ s/^[\x{0301}\x{030C}]+//;
}

{ # GH 16627
fresh_perl('use re "eval";
my @r;
for $0 (qw(0 0)) {
push @r, qr/@r(?{})/;
}',
{ stderr => 'devnull' });
is($?, 0, "No segfault; [GH 16627]");
}


# !!! NOTE that tests that aren't at all likely to crash perl should go
# a ways above, above these last ones. There's a comment there that, like
Expand Down
14 changes: 0 additions & 14 deletions t/run/todo.t
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,6 @@ my $switches = "";

my $is_debugging_build = $Config{cppflags} =~ /-DDEBUGGING/;


{ # Fixed by acababb42be12ff2986b73c1bfa963b70bb5d54e
"abab" =~ /(?:[^b]*(?=(b)|(a))ab)*/;
is($1, undef, "GH #16894");
}

our $TODO;

TODO: {
Expand Down Expand Up @@ -187,12 +181,4 @@ TODO: {

}

{
fresh_perl('use re "eval";
my @r;
for$0(qw(0 0)){push@r,qr/@r(?{})/};',
{ stderr => 'devnull' });
is($?, 0, "No assertion failure");
}

done_testing();
Loading