-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Support passing PSPath to native commands #12386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
change string comparison to use string static methods
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
…Binder.cs Co-Authored-By: Ilya <darpa@yandex.ru>
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
@PoshChan retry macos |
@SteveL-MSFT, successfully started retry of |
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
@PoshChan retry windows |
@SteveL-MSFT, successfully started retry of |
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
test/powershell/Language/Scripting/NativeExecution/NativeCommandArguments.Tests.ps1
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
…case for relative pspath, add test case for complex psdrive name
c85c7ed
to
cf70fcc
Compare
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
…bing API returns z:\ for just z: which is not correct
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
@PoshChan please retry windows |
@SteveL-MSFT, successfully started retry of |
Added doc issue: MicrosoftDocs/PowerShell-Docs#5848 |
🎉 Handy links: |
PR Summary
Add a new
PSNativePSPathResolution
Experimental Feature where if a PSDrive is passed to a native command and uses the FileSystem provider, then the resolved file path is passed to the native command. This means something like:code temp:/test.txt
now works as expected. Also, on Windows, if the path starts with
~
, then that will get resolved before passing to a native command. In both cases, the path is normalized to the directory separators for the relevant operating system. Note:PR Context
Fix #10675
Fix #11386
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.