Skip to content

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jun 2, 2020

PR Summary

Add settings from https://github.com/dotnet/runtime/blob/master/.editorconfig

We may want a different value for of the new settings, so please leave review comments,

PR Context

#7357

PR Checklist

@ghost ghost assigned TravisEz13 Jun 2, 2020
@TravisEz13 TravisEz13 requested a review from iSazonov June 2, 2020 18:27
@TravisEz13 TravisEz13 added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jun 2, 2020
@xtqqczze

This comment has been minimized.

@iSazonov
Copy link
Collaborator

iSazonov commented Jun 8, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@iSazonov
Copy link
Collaborator

iSazonov commented Jun 8, 2020

@xtqqczze Please rebase to fix CI-static.

@xtqqczze xtqqczze force-pushed the update-editorconfig branch from 2899921 to 0086e8c Compare June 8, 2020 09:48
@TravisEz13
Copy link
Member

cc @daxian-dbw @adityapatwardhan Can you review?

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 22, 2020
@ghost
Copy link

ghost commented Jun 22, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@TravisEz13
Copy link
Member

cc @daxian-dbw @adityapatwardhan Can you review?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 22, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 30, 2020
@ghost
Copy link

ghost commented Jun 30, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

@daxian-dbw Can you please review?

@TravisEz13 TravisEz13 merged commit 940cd74 into PowerShell:master Jun 30, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 30, 2020
@xtqqczze xtqqczze deleted the update-editorconfig branch June 30, 2020 17:45
@iSazonov iSazonov added this to the 7.1.0-preview.5 milestone Jun 30, 2020
@ghost
Copy link

ghost commented Jul 6, 2020

🎉v7.1.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants