Skip to content

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Nov 26, 2018

PR Summary

Related #3565 and #4357.

Easily review commit by commit:

  • Remove old code for WebClient - currently HTTPClient is main in CoreFX.
  • Restore XML Schema support - currently we have the API in CoreFX.
  • Reorder using statements.

PR Checklist

@iSazonov
Copy link
Collaborator Author

Tests failed with "The Help content XSD file cannot be found in C:\projects\powershell\src\powershell-win-core\bin\Release"

I see that Windows PowerShell has Schemas directory in home folder.

Should we restore this or remove schemas support?

@adityapatwardhan
Copy link
Member

@iSazonov Thanks for this PR. We should bring back the schema files as XSD validation seems to be supported in CoreCLR now.

@iSazonov
Copy link
Collaborator Author

@adityapatwardhan Please point me where I can get this files from. Can I copy them to the repo from Windows PowerShell directory?

@iSazonov iSazonov force-pushed the cleanup-updatablehelpsystem branch from 74aca01 to 2bf264c Compare November 29, 2018 13:53
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 29, 2018
@iSazonov
Copy link
Collaborator Author

@adityapatwardhan Schemas added.

Copy link
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title to mention enable XSD validation of maml help

@adityapatwardhan adityapatwardhan changed the title Cleanup updatablehelpsystem Cleanup updatablehelpsystem and enable XSD validation on MAML help content Nov 29, 2018
@adityapatwardhan adityapatwardhan merged commit 6dcd3ad into PowerShell:master Nov 29, 2018
@iSazonov iSazonov deleted the cleanup-updatablehelpsystem branch November 30, 2018 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants