Remove broken HelpUri from CimTest #8688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fwlink redirects to `http://technet.microsoft.comlibrary/jj635727(v=wps.620).aspx`. With the missing forward slash added the fwlink redirects to `http://docs.microsoft.com/en-us/powershell/module/smbshare/set-smbshare?view=winserver2012-ps1`
8 tasks
xtqqczze
changed the title
daxian-dbw
added
the
CL-Test
adityapatwardhan
approved these changes
Jan 18, 2019
|
The change looks good. Does not seem to be used in any tests. We typically wait 24 hours for the PR for comments. I will merge this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove broken HelpUri from CimTest.cdxml as it appears to be redundant.
PR Context
During #8622 it was found this URI is broken as the fwlink redirects to
http://technet.microsoft.comlibrary/jj635727(v=wps.620).aspx(note missing forward slash)With the missing forward slash added the fwlink redirects to
http://docs.microsoft.com/en-us/powershell/module/smbshare/set-smbshare?view=winserver2012-ps1which doesn't appear to be relevant to the test.@JamesWTruher
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests