Skip to content

Suggest "-id pid" for "Get-Process pid" #8959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 1, 2019
Merged

Suggest "-id pid" for "Get-Process pid" #8959

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d3d577f
pid suggestion for get-process
MohiTheFish Feb 23, 2019
fa9d822
changed error message, cleaned syntax
MohiTheFish Feb 23, 2019
6d5a74b
[feature] whitespace
MohiTheFish Feb 23, 2019
f929984
[feature] switches the error upon encountering positive integer
MohiTheFish Feb 24, 2019
d652256
whitespace and added labels
MohiTheFish Feb 24, 2019
d3e9291
Updating Process.cs
MohiTheFish Feb 24, 2019
b1c6124
Update inequality test
rjmholt Mar 1, 2019
8ac574f
Use nameof in error call
rjmholt Mar 1, 2019
2ff3c42
Use nameof in other error name because I can't read
rjmholt Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,14 +189,23 @@ private void RetrieveMatchingProcessesByProcessName()
if (!found &&
!WildcardPattern.ContainsWildcardCharacters(pattern))
{
string errorText = ProcessResources.NoProcessFoundForGivenName;
string errorName = "NoProcessFoundForGivenName";

if (int.TryParse(pattern, out int x) && x >= 0)
{
errorText = ProcessResources.RecommendIdTagForGivenName;
errorName = "RecommendIdTagForGivenName";
}

WriteNonTerminatingError(
pattern,
0,
pattern,
null,
ProcessResources.NoProcessFoundForGivenName,
"NoProcessFoundForGivenName",
ErrorCategory.ObjectNotFound);
processName: pattern,
processId: 0,
targetObject: pattern,
innerException: null,
resourceId: errorText,
errorId: errorName,
category: ErrorCategory.ObjectNotFound);
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions src/Microsoft.PowerShell.Commands.Management/resources/ProcessResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@
<data name="NoProcessFoundForGivenName" xml:space="preserve">
<value>Cannot find a process with the name "{0}". Verify the process name and call the cmdlet again.</value>
</data>
<data name="RecommendIdTagForGivenName" xml:space="preserve">
<value>Cannot find a process with the name "{0}". Try running with -Id to search by Id of processes.</value>
</data>
<data name="NoDebuggerFound" xml:space="preserve">
<value>This command cannot be run because the debugger cannot be attached to the process "{0} ({1})". Specify another process and Run your command.</value>
</data>
Expand Down