Skip to content

Conversation

brian-rose
Copy link
Member

Closes #521

This PR moves all logos and images below the main title for every page. This should resolve the duplicate title issue.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Jun 18, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: c585c62
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/524

@brian-rose brian-rose marked this pull request as ready for review June 18, 2025 19:33
@brian-rose brian-rose requested a review from a team as a code owner June 18, 2025 19:33
@brian-rose brian-rose requested review from ktyle and r-ford and removed request for a team June 18, 2025 19:33
Copy link
Member

@r-ford r-ford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm seeing some issue with the NumPy logo in the section .md file:
image

@brian-rose
Copy link
Member Author

Looks good, but I'm seeing some issue with the NumPy logo in the section .md file:

Good catch, should be fixed now.

@brian-rose
Copy link
Member Author

brian-rose commented Jun 18, 2025

Currently the Numpy logo renders at different sizes on this page and this page even though both specify width=250. This is the same issue with raw HTML <img> tags as discussed in ProjectPythia/cookbook-template#226.

@brian-rose brian-rose merged commit 6e52c60 into ProjectPythia:main Jun 18, 2025
3 checks passed
@brian-rose brian-rose deleted the fix-titles branch June 18, 2025 20:09
github-actions bot pushed a commit that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated titles on many pages
2 participants