Skip to content

summarize: Small variable rename and handle engine not found case #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2018
Merged

summarize: Small variable rename and handle engine not found case #131

merged 4 commits into from
Oct 20, 2018

Conversation

bact
Copy link
Member

@bact bact commented Oct 20, 2018

  • add __ prefix for private class members
  • summarize_text() will always return something (if summarization engine not found, return first n sentences)
  • summarize_text() documentation

bact added 3 commits October 16, 2018 06:24
@bact
Merge pull request #2 from PyThaiNLP/dev
a6b5032 
Merge back from PyThaiNLP main repo
@bact
Small variable rename and handle engine not found case
04b22d8 
- add __ prefix for private class members
- summarize_text() will always return something (if summarization engine not found, return first n sentences)
@bact
Merge branch 'dev' of https://github.com/bact/pythainlp into dev
ef406ce 
* 'dev' of https://github.com/bact/pythainlp:
@coveralls
Copy link

coveralls commented Oct 20, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 53.214% when pulling c1296d7 on bact:dev into 3307699 on PyThaiNLP:dev.

@wannaphong wannaphong merged commit 64519a5 into PyThaiNLP:dev Oct 20, 2018
@wannaphong
Copy link
Member

รวมเรียบร้อยแล้ว ขอบคุณครับ

@wannaphong wannaphong mentioned this pull request Nov 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @coveralls @wannaphong