Skip to content

[MRG] Actually run sphinx-gallery #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 21, 2020
Merged

[MRG] Actually run sphinx-gallery #146

merged 11 commits into from
Apr 21, 2020

Conversation

rflamary
Copy link
Collaborator

up to new sphinx-gallery is executed offline and the resulting files are added to the git.

This PR aim at making it run on circle-ci in order to alwyas have current examples in the documentation.

@agramfort
Copy link
Collaborator

need help @rflamary ?

@codecov-io
Copy link

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files          15       15           
  Lines        3023     3023           
=======================================
  Hits         2750     2750           
  Misses        273      273           

Copy link
Collaborator

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hichamjanati
Copy link
Contributor

Woah 🎉 👍

@rflamary rflamary changed the title [WIP] Actually run sphinx-gallery [MRG] Actually run sphinx-gallery Apr 21, 2020
@rflamary
Copy link
Collaborator Author

Yes it is awesome.

I Updated the readme. Will merge as soon as i see no problems

@agramfort agramfort merged commit a303cc6 into master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants