Skip to content

[MRG] Distance calculation bug solve #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2021

Conversation

ncassereau
Copy link
Contributor

@ncassereau ncassereau commented Nov 8, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

Resolves #305, also allows the usage of weights (otherwise wminkowski is not a valid metric contrary to what POT doc suggests)

How has this been tested (if it applies)

Tests ran locally without a hitch

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@ncassereau ncassereau changed the title [WIP] Distance calculation bug solve [MRG] Distance calculation bug solve Nov 8, 2021
@ncassereau ncassereau marked this pull request as ready for review November 8, 2021 10:23
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #306 (4de4f54) into master (f162879) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   93.38%   93.43%   +0.04%     
==========================================
  Files          21       21              
  Lines        4886     4888       +2     
==========================================
+ Hits         4563     4567       +4     
+ Misses        323      321       -2     

@rflamary rflamary merged commit 0c58991 into PythonOT:master Nov 8, 2021
@ncassereau ncassereau deleted the cityblock_bug branch November 8, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cityblock distance: Invalid arguments
2 participants