[WIP] Silence std::cerr calls inside of python #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Adds flags to disable std::cerr reporting in the cpp backend. Adds parameter
ot.backend.use_cerr
as parameter andot.backend.get_cerr()
getter to enable/disablecerr
reporting inside of python. The parameter defaults to False.Motivation and context / Related issue
We are using POT inside of jupyter notebook and running into a problem that hits its iter limits. The warnings flood our console. Because the backend code is calling std::cerr directly, rather than passing the error string up to the python stderr stream, traditional context management based redirection (or simply killing sys.stderr inside of python) does not work.
How has this been tested (if it applies)
Have tested the basic use case and enable/disabling the cerr. Works in ipython on 3.9.7.
PR checklist