Skip to content

Using log parameter #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2018
Merged

Using log parameter #44

merged 5 commits into from
Apr 18, 2018

Conversation

tardyb
Copy link
Contributor

@tardyb tardyb commented Apr 18, 2018

I have added the use of log parameter in class EMDTransport and SinkhornLpL1Transport, where it was not used. Related discussion here: #43

@rflamary
Copy link
Collaborator

Hello @tardyb and thank you for the PR,

Currently the build fails because of small pep8 problems. Note that we enforce strict pep8 in all the POT code which can be done automatically with autopep8

$ flake8 examples/ ot/ test/
ot/da.py:1335:55: E231 missing whitespace after ','
ot/da.py:1339:1: W293 blank line contains whitespace
ot/da.py:1494:37: E231 missing whitespace after ','
The command "flake8 examples/ ot/ test/" exited with 1.

but since you only have 3 problems they can be easily corrected directly in the code.

Once the code build I think we can quickly merge your PR.

@rflamary rflamary merged commit 9473929 into PythonOT:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants