Skip to content

Stop building Boot images #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

alexander-yakushev
Copy link
Contributor

As discussed in #224.

@cap10morgan
Copy link
Collaborator

@alexander-yakushev Thanks! Can you split up the src/ changes from the target/ changes into separate commits?

@alexander-yakushev
Copy link
Contributor Author

Done!

Copy link
Collaborator

@cap10morgan cap10morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things to address, but looking good overall!

@alexander-yakushev
Copy link
Contributor Author

alexander-yakushev commented Apr 23, 2024

Done.

Copy link
Collaborator

@cap10morgan cap10morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cap10morgan cap10morgan requested a review from Quantisan April 23, 2024 15:36
Copy link
Owner

@Quantisan Quantisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cap10morgan cap10morgan merged commit 0e09eef into Quantisan:master Apr 23, 2024
@alexander-yakushev alexander-yakushev mentioned this pull request Apr 23, 2024
@alexander-yakushev alexander-yakushev deleted the boot-the-boot branch April 23, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants