-
Notifications
You must be signed in to change notification settings - Fork 74
Resolve compiler errors due to rank mismatches #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve compiler errors due to rank mismatches #138
Conversation
4551f13
to
b656c9c
Compare
b656c9c
to
4dc085a
Compare
Hi @G-Ragghianti, what you are doing looks good to me, I see that you have this as WIP, so let us know when you think you are done and we can review. Julien. |
It was mainly a WIP because I was wanting to also include updated in TESTING/LIN/*, but that has a different problem that will be more difficult to resolve. I think this is ready to go. |
@langou I forgot that I also attempted to resolve a problem in the github workflow due to a missing blas/lapack provider. My first attempt didn't work, so let's see if I can get that working or remove the changes in main.yml. |
I've added sudo to install openblas0 in the workflow runner. Let's see if the workflow can run now. |
@langou Can you approve the CI checks to run for this PR? |
@G-Ragghianti It looks like there are merge conflicts on |
The conflict in the make.yml is
We have an issue with
And I merged #141 to try to fix this. I will resolve the conflicts and get this through the CI again. |
OKey doc great. #141 seems to do the trick. Good. |
Work in progressto resolve compiler complaints:Error: Rank mismatch between actual argument at (1) and actual argument at (2) (scalar and rank-1)
by promoting some scalars to single element arrays.