Skip to content

Resolve compiler errors due to rank mismatches #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

G-Ragghianti
Copy link
Contributor

@G-Ragghianti G-Ragghianti commented Jul 4, 2025

Work in progress to resolve compiler complaints:

Error: Rank mismatch between actual argument at (1) and actual argument at (2) (scalar and rank-1)

by promoting some scalars to single element arrays.

@G-Ragghianti G-Ragghianti force-pushed the gragghia/implicit_func branch from 4551f13 to b656c9c Compare July 4, 2025 12:42
@G-Ragghianti G-Ragghianti force-pushed the gragghia/implicit_func branch from b656c9c to 4dc085a Compare July 4, 2025 12:46
@langou
Copy link
Contributor

langou commented Jul 10, 2025

Hi @G-Ragghianti, what you are doing looks good to me, I see that you have this as WIP, so let us know when you think you are done and we can review. Julien.

@G-Ragghianti
Copy link
Contributor Author

It was mainly a WIP because I was wanting to also include updated in TESTING/LIN/*, but that has a different problem that will be more difficult to resolve. I think this is ready to go.

@mgates3

@G-Ragghianti
Copy link
Contributor Author

@langou I forgot that I also attempted to resolve a problem in the github workflow due to a missing blas/lapack provider. My first attempt didn't work, so let's see if I can get that working or remove the changes in main.yml.

@G-Ragghianti
Copy link
Contributor Author

I've added sudo to install openblas0 in the workflow runner. Let's see if the workflow can run now.

@G-Ragghianti
Copy link
Contributor Author

@langou Can you approve the CI checks to run for this PR?

@mgates3
Copy link
Contributor

mgates3 commented Jul 16, 2025

@G-Ragghianti It looks like there are merge conflicts on make.yml.

@langou
Copy link
Contributor

langou commented Jul 16, 2025

The conflict in the make.yml is

<<<<<<< gragghia/implicit_func
    - name: Install OpenBLAS
      run: |
        sudo apt-get update
        sudo apt-get -y install libopenblas0
=======
    - name: Install BLAS and LAPACK
      run: sudo apt -y install libblas-dev liblapack-dev
>>>>>>> master

We have an issue with

mpif90 -O3 -o xspblas1tst psblas1tst.o psblastst.o slamch.o pblastst.o PB_Cwarn.o PB_Cabort.o ../../libscalapack.a -llapack -lblas
/usr/bin/ld: cannot find -llapack: No such file or directory
/usr/bin/ld: cannot find -lblas: No such file or directory

And I merged #141 to try to fix this.

I will resolve the conflicts and get this through the CI again.

@langou
Copy link
Contributor

langou commented Jul 16, 2025

OKey doc great. #141 seems to do the trick. Good.
Thanks @hughcars for #141
Thanks @G-Ragghianti for #138

@langou langou merged commit 6f56981 into Reference-ScaLAPACK:master Jul 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants