-
-
Notifications
You must be signed in to change notification settings - Fork 38
SimpleAdaptiveTauLeaping solver #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sivasathyaseeelan
wants to merge
24
commits into
SciML:master
Choose a base branch
from
sivasathyaseeelan:adaptive-implicit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+322
−31
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4699990
Implemented SimpleAdaptiveTauLeaping and SimpleImplicitTauLeaping
sivasathyaseeelan 91ff58b
update project.toml
sivasathyaseeelan 31562bb
test changes
sivasathyaseeelan bd4a452
refactor
sivasathyaseeelan e5455b6
test refactor
sivasathyaseeelan 683a2c0
refactor
sivasathyaseeelan 75a733f
added saveat in SimpleAdaptiveTauLeaping
sivasathyaseeelan 7f21b85
update
sivasathyaseeelan 73172e3
Update src/simple_regular_solve.jl
sivasathyaseeelan e2bb2f3
Update src/simple_regular_solve.jl
sivasathyaseeelan 750511d
update
sivasathyaseeelan 38a5c3d
test update
sivasathyaseeelan 2df7477
using maj for adaptive tauleaping
sivasathyaseeelan 145fd49
project.toml update
sivasathyaseeelan 24a191a
saveat logic change
sivasathyaseeelan c561fa4
test change
sivasathyaseeelan 341b370
saveat optimization
sivasathyaseeelan 0f7fb4d
refactor
sivasathyaseeelan 577f9e1
memory optimization
sivasathyaseeelan af0ec6e
validate_pure_leaping_inputs extended for adaptive version
sivasathyaseeelan 01e7527
some
sivasathyaseeelan 6e6631c
space optimized in compute_tau_explicit
sivasathyaseeelan 2f66602
computegi and comutehor changes
sivasathyaseeelan 43426a8
reactant_stoch in hor
sivasathyaseeelan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the full PR carefully, but this function still looks wrong to me. Look at Section IV of the paper at the text between (27) and (28).
x_i
there is notstoch
it is thei
th species (i.e.u_i
).Also, you should be precalculating if any reaction with
HOR[i] == 2
has speciesi
with substrate stoichiometry of 2 (and the related conditions whenHOR[i] == 3
). This is determined fromreactant_stoch
not the net stoichiometry matrixnu
.If I can make a suggestion, perhaps it makes sense for you to go back and work on finishing the GPU method PR. It seems like you are having some conceptual issues with the paper here, whereas that PR just involves some basic code modifications to get finished and so should be an easier task. Once that is done and merged perhaps you can more carefully read this paper, particularly Section IV, and then return to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if you have specific questions on the method of the paper please ask on Slack! That might help clarify your understanding / fix any confusion.