Update extended Property Conditions #7566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
bug
sovdeeth
approved these changes
Feb 2, 2025
src/main/java/ch/njol/skript/conditions/CondIsInteractable.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIgnitionProcess.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondEntityIsInLiquid.java
Outdated
Show resolved
Hide resolved
cheeezburga
approved these changes
Feb 5, 2025
src/main/java/org/skriptlang/skript/bukkit/fishing/elements/CondIsInOpenWater.java
Outdated
Show resolved
Hide resolved
cheeezburga
added
the
feature-ready
|
Doesn't the new registration have a way to set parsing data? Wouldn't it be beneficial to utilize that instead of having to use the method? |
sovdeeth
requested review from
UnderscoreTud and
erenkarakal
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What initially started off as me adding the missing
getPropertyTypeto the property conditions that needed it, ended leading to updating other classes to current conventions.Target Minecraft Versions: any
Requirements: none
Related Issues: none