Skip to content

Conversation

yzz17
Copy link
Contributor

@yzz17 yzz17 commented Feb 5, 2025

Description

Proposal to officially add Spanish to the lang, attempt 3, It's my first pull request :S


Target Minecraft Versions: any
Requirements: none
Related Issues: #7582

Proposal to officially add Spanish to the lang, attempt 3, It's my first pull request :S
@yzz17
Copy link
Contributor Author

yzz17 commented Feb 5, 2025

@erenkarakal

thx, I think it's correct now, thanks for your patience.

Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fyi, you don't need to re-open prs to make changes, you can just make another commit and push it, and it'll add on to the open pr :)

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Copy link
Member

@erenkarakal erenkarakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs reviews from a few people who speak Spanish

@Efnilite Efnilite added the translation Pull requests that are aiming to add new translations to Skript label Feb 8, 2025
@TwistedWar3713
Copy link
Contributor

Needs reviews from a few people who speak Spanish

Hello, I am actually native from Spain. I read the whole thing and unless there's a syntax error every translation is correct, I also made a translation myself before acknowledging this one (and one also in catalan) but since it's correct you could add it to the plugin.

@Lukarius11
Copy link

I am a Spanish speaker, I see that the code is fine, you could add it to the plugin 👍🏻

@Efnilite Efnilite requested review from sovdeeth and erenkarakal March 9, 2025 10:22
Copy link
Member

@erenkarakal erenkarakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

half of the file uses spaces, while the other uses tab for indentation. can you change it all to tabs?

yzz17 added 2 commits March 9, 2025 08:29
I checked line by line and now they should all be starting with tabs and not spaces.
@yzz17
Copy link
Contributor Author

yzz17 commented Mar 9, 2025

Needs reviews from a few people who speak Spanish

Hello, I am actually native from Spain. I read the whole thing and unless there's a syntax error every translation is correct, I also made a translation myself before acknowledging this one (and one also in catalan) but since it's correct you could add it to the plugin.

Creo que vas a necesitar esto para tú pull #7685, gracias por el apoyo, al parecer ya solo falta 1 review en este pull: # Which language to use. Currently English, Catalan, German, Korean, French, Polish, Russian, Japanese, Simplified Chinese, Turkish, Dutch and Spanish

@TwistedWar3713
Copy link
Contributor

Needs reviews from a few people who speak Spanish

Hello, I am actually native from Spain. I read the whole thing and unless there's a syntax error every translation is correct, I also made a translation myself before acknowledging this one (and one also in catalan) but since it's correct you could add it to the plugin.

Creo que vas a necesitar esto para tú pull #7685, gracias por el apoyo, al parecer ya solo falta 1 review en este pull: # Which language to use. Currently English, Catalan, German, Korean, French, Polish, Russian, Japanese, Simplified Chinese, Turkish, Dutch and Spanish

Sí, también me han pedido verificación, es normal y una buena medida de precaución. Encontrar hablantes de Catalán supongo que será más complicado pero un amigo ya pudo revisarlo, que es quién te ha comentado también. Y el español deberías ponerlo despúes del Chino según su orden alfabético Jajaja.

@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 16, 2025
@Efnilite Efnilite requested a review from a team as a code owner March 20, 2025 14:29
@Efnilite Efnilite requested review from Pikachu920 and Pesekjak March 20, 2025 14:29
@sovdeeth sovdeeth removed the request for review from a team March 21, 2025 01:51
@sovdeeth sovdeeth merged commit 85df5fe into SkriptLang:dev/feature Mar 21, 2025
5 checks passed
@Florenthz

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. translation Pull requests that are aiming to add new translations to Skript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants