-
-
Notifications
You must be signed in to change notification settings - Fork 404
Add spanish.lang #7586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spanish.lang #7586
Conversation
Proposal to officially add Spanish to the lang, attempt 3, It's my first pull request :S
thx, I think it's correct now, thanks for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fyi, you don't need to re-open prs to make changes, you can just make another commit and push it, and it'll add on to the open pr :)
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs reviews from a few people who speak Spanish
Hello, I am actually native from Spain. I read the whole thing and unless there's a syntax error every translation is correct, I also made a translation myself before acknowledging this one (and one also in catalan) but since it's correct you could add it to the plugin. |
I am a Spanish speaker, I see that the code is fine, you could add it to the plugin 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
half of the file uses spaces, while the other uses tab for indentation. can you change it all to tabs?
I checked line by line and now they should all be starting with tabs and not spaces.
Creo que vas a necesitar esto para tú pull #7685, gracias por el apoyo, al parecer ya solo falta 1 review en este pull: # Which language to use. Currently English, Catalan, German, Korean, French, Polish, Russian, Japanese, Simplified Chinese, Turkish, Dutch and Spanish |
Sí, también me han pedido verificación, es normal y una buena medida de precaución. Encontrar hablantes de Catalán supongo que será más complicado pero un amigo ya pudo revisarlo, que es quién te ha comentado también. Y el español deberías ponerlo despúes del Chino según su orden alfabético Jajaja. |
Description
Proposal to officially add Spanish to the lang, attempt 3, It's my first pull request :S
Target Minecraft Versions: any
Requirements: none
Related Issues: #7582