Add EntityShootBowEvent #7714
Merged
Add EntityShootBowEvent #7714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Based off test, this always returns true
Efnilite
requested changes
Mar 16, 2025
Efnilite
requested changes
Mar 16, 2025
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
Efnilite
requested changes
Mar 16, 2025
src/main/java/ch/njol/skript/expressions/ExprProjectileForce.java
Outdated
Show resolved
Hide resolved
Whoops Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Efnilite
approved these changes
Mar 16, 2025
Co-authored-by: Shane Bee <shanebolenback@me.com>
Co-authored-by: Shane Bee <shanebolenback@me.com>
Absolutionism
approved these changes
Mar 17, 2025
Efnilite
approved these changes
Mar 17, 2025
sovdeeth
requested changes
Mar 22, 2025
Fusezion
requested review from
cheeezburga and
erenkarakal
and removed request for
a team
sovdeeth
requested changes
Mar 23, 2025
sovdeeth
approved these changes
Mar 23, 2025
sovdeeth
added
the
feature-ready
skriptlang-automation
bot
added
completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add the entity shoot bow event, and most of it's related syntax.
The only syntax not included in this are the
shouldConsumeandsetConsumeItemthe reason for this is their current lack of functionality,setConsumeItemis deprecated due to not being implemented, andshouldConsumeseems to always return true.This was tested with both entities, survival mode and creative mode
I am currently unsure how implementing a test for this would go
Any feedback regarding how the expression syntax would be great
shot forceisn't great, but there just doesn't feel like any better terms for it.Consumed item was decided on due to it's generic name making this expression easily expandable into other events with similar methods.
Target Minecraft Versions: 2.11.1
Requirements: none
Related Issues: #6403