Add Timespan add/subtract/diff methods #7883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
requested review from
cheeezburga and
UnderscoreTud
and removed request for
a team
erenkarakal
added
the
enhancement
UnderscoreTud
approved these changes
May 20, 2025
src/main/java/ch/njol/skript/classes/data/DefaultOperations.java
Outdated
Show resolved
Hide resolved
Efnilite
approved these changes
May 21, 2025
skriptlang-automation
bot
added
the
patch-ready
APickledWalrus
approved these changes
May 22, 2025
Missed it, changing now |
sovdeeth
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Having to write unnecessary code to get the timespan arithmetic operation, just for simple additions and subtractions.
Solution
Moves the arithmetic code inside the Timespan class so that the methods can be used quickly.
Testing Completed
Manual testing was done to ensure that overflowing and underflowing are properly handled and that simple operations work fine. No code was changed, only moved around.
Supporting Information
This was discussed in the dev channel
Completes: none
Related: none