Skip to content

Webhook callback url -> webhook url #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jul 9, 2025

Important

Rename 'Webhook Callback URL' to 'Webhook URL' across documentation, frontend, and backend for consistency.

  • Renames:
    • Rename 'Webhook Callback URL' to 'Webhook URL' in fern/integrations/workato.mdx, fern/integrations/zapier.mdx, and skyvern_openapi.json.
    • Update displayName and description in Skyvern.node.ts.
    • Change labels in CreateNewTaskForm.tsx, PromptBox.tsx, SavedTaskForm.tsx, TaskParameters.tsx, RunWorkflowForm.tsx, StartNode.tsx, and WorkflowPostRunParameters.tsx.
    • Update comments and logging messages in agent.py and service.py.
  • Behavior:
    • No functional changes; purely a terminology update for clarity and consistency.

This description was created by Ellipsis for 53a1224. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 53a1224 in 1 minute and 44 seconds. Click for details.
  • Reviewed 245 lines of code in 14 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. skyvern/services/task_v2_service.py:1690
  • Draft comment:
    Use a context manager for httpx.AsyncClient to ensure connection closure instead of instantiating it directly.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. skyvern/services/task_v2_service.py:393
  • Draft comment:
    The helper function 'run_task_v2_helper' is very long and complex; consider refactoring into smaller, modular helper functions for improved readability and maintainability.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. skyvern/services/task_v2_service.py:1368
  • Draft comment:
    Each call to _generate_random_string seeds the random generator using os.urandom; consider seeding once globally to avoid potential performance overhead.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. skyvern/services/task_v2_service.py:1695
  • Draft comment:
    Logging the complete webhook payload may expose sensitive data; consider sanitizing or redacting sensitive fields.
  • Reason this comment was not posted:
    Comment was on unchanged code.
5. skyvern/services/task_v2_service.py:1500
  • Draft comment:
    Avoid using bare 'except Exception:' clauses; catch more specific exceptions or re-raise after logging to prevent masking underlying issues.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_dztqZ0QegVk2T3HG

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants