[WIP] Support Current domain in ingestion code #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+415
to
+419
| # In the case that current domain is non-empty, we need to consider it | ||
| if hasattr(schema, "current_domain") and not schema.current_domain.is_empty: | ||
| dimensions = np.int64(schema.current_domain.dim(0).domain[1]) + 1 | ||
| else: | ||
| dimensions = np.int64(schema.domain.dim(0).domain[1]) + 1 |
There was a problem hiding this comment.
Because the number of dimensions is an immutable value that is selected at the time of creating the embeddings, it seems more appropriate to use the similarly immutable domain of TileDB arrays.
If we want to support ingesting a subset of dimensions from the input file, I think we should have the user explicitly specify it, rather than guessing it from sources like the current domain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564
[sc-62701]