Additional fixes for PHP8.1 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alquerci
approved these changes
Aug 17, 2022
|
All my Apologies for the delay ! |
thePanz
pushed a commit
that referenced
this pull request
Nov 25, 2022
thePanz
pushed a commit
that referenced
this pull request
Nov 25, 2022
ValueError: fread(): Argument FriendsOfSymfony1#2 ($length) must be greater than 0 TypeError: count(): Argument #1 ($value) must be of type Countable|array Foo Given Use Symfony Polyfill symfony/polyfill@d330c00 TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given Do not use Symfony pollyfill, is_array is enought
Tybaze
pushed a commit
that referenced
this pull request
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PHP8.1, file uploads have a new
full_pathparameter which symfony1 forms don't recognize and creates all sort of form validation errors. Following symfony2+, we can simply unset it. If one truly needs to use it, it can be obtained from$_FILES.Also, a few more fixes for uses of null where string is expected.