-
Notifications
You must be signed in to change notification settings - Fork 752
Support all garbage collector tests #2622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zherczeg
wants to merge
6
commits into
WebAssembly:main
Choose a base branch
from
zherczeg:gc_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support named references for globals, locals, tables, elems Support named references for call_ref, ref_null Extend Var variables with an optional type field
e973c0b
to
2426298
Compare
It looks like garbage collection tests are finally working. It took me 4 months, but the initial version of garbage collection support is completed. I think I understand the concept of references in WebAssembly, and know why it works that way. The code probably needs a lot of changes. |
b043e58
to
645b133
Compare
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 15, 2025
from: WebAssembly/wabt#2622 https://github.com/zherczeg/wabt/tree/gc_tests Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 16, 2025
from: https://github.com/zherczeg/wabt/tree/gc_tests (1917fb3) WebAssembly/wabt#2622 Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 18, 2025
from: https://github.com/zherczeg/wabt/tree/gc_tests (1917fb3) WebAssembly/wabt#2622 Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 22, 2025
from: https://github.com/zherczeg/wabt/tree/gc_tests (1917fb3) WebAssembly/wabt#2622 Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 22, 2025
from: https://github.com/zherczeg/wabt/tree/gc_tests (1917fb3) WebAssembly/wabt#2622 Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for all tests in
testsuite/proposals/gc
. Two tests are still missing.