Skip to content

1009117 Refactored for readability #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 23, 2025
Merged

1009117 Refactored for readability #225

merged 24 commits into from
May 23, 2025

Conversation

andyreidz
Copy link
Member

No description provided.

@andyreidz andyreidz self-assigned this May 19, 2025
@andyreidz andyreidz changed the base branch from develop to US1009117 May 19, 2025 16:13
@buildmachine-sou-jenkins2
Copy link
Contributor

@buildmachine-sou-jenkins2
Copy link
Contributor

The Documentation QA site for this branch has been built:
https://workerframework-ci-worker-framework-1009117-review-441722.glpages.otxlab.net

@DavidGerald-Milligan
Copy link
Member

@andyreidz I have reviewed again and made some minor updates to tests. I deployed update-entities and classification workers employing this build, and the updated message-distribution worker where we pass the original headers on larry and re-tested the 'mark false positive' function. The the headers are passed through to the workers and the issue of the message looping is no longer present. The flow through the workers is good, and I checked the datastore on larry and the stored files are cleaned up as expected, though I do notice that the directories created in storing the taskMessage are still present, albeit empty.

@andyreidz andyreidz merged commit 9fd3ff8 into US1009117 May 23, 2025
@andyreidz andyreidz deleted the 1009117-review branch May 23, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants