fix(api/process): fix snapshot cache for GPU processes with shared host process #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
XuehaiPan
force-pushed
the
fix-cpu-snapshot
branch
from
f94b404 to
03e8754
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the snapshot cache handling for GPU processes that share a host process. The issue was caused by the original code using the or operator which would reassign an empty cache dictionary to a new instance, breaking cache sharing between processes.
- Replaces the
oroperator with explicitNonecheck to preserve empty cache dictionaries - Updates CHANGELOG.md to document the bug fix and a minor TUI improvement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nvitop/api/process.py | Fixes cache handling logic to preserve empty dictionaries instead of reassigning them |
| CHANGELOG.md | Documents the bug fix and an unrelated TUI display improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Type
Description
Do not reassign the cache to a new
dictif it is empty.Motivation and Context
Fixes #171