Skip to content

Conversation

gaya3-zipstack
Copy link
Contributor

What

Fix regex pattern for validating pages to extract in LLMWhisperer adapter

Why

The field was not taking empty as a valid value and was forcing user to enter an empty space

How

Change regex pattern used for validation

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

...

Screenshots

...

Checklist

I have read and understood the Contribution Guidelines.

@gaya3-zipstack gaya3-zipstack requested review from a team, muhammad-ali-e and kirtimanmishrazipstack and removed request for a team July 12, 2024 06:15
Copy link

@kirtimanmishrazipstack kirtimanmishrazipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@muhammad-ali-e muhammad-ali-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I beleive we tested the regex. Left one comment.

@gaya3-zipstack gaya3-zipstack merged commit c2fd96f into main Jul 18, 2024
@gaya3-zipstack gaya3-zipstack deleted the fix/llm-whisp-pages-to-extract branch July 18, 2024 08:58
@gaya3-zipstack gaya3-zipstack restored the fix/llm-whisp-pages-to-extract branch July 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants