Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Mar 2, 2015

Bump version number to 1.2

Bump version number to 1.2
@@ -15,7 +15,7 @@ back and forth between your real source code and the browser view.
* **Do it yourself.** Because Brackets is open source, and built with HTML, CSS
and JavaScript, you can [help build](https://github.com/adobe/brackets/blob/master/CONTRIBUTING.md) the best code editor for the web.

Brackets is at 1.0 and we're not stopping there. We have many feature ideas on our
Brackets is at 1.2 and we're not stopping there. We have many feature ideas on our
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to update this for every release. I think the intent is more like "Brackets is at version 1 and we're not stopping there."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Brackets may have reached version 1, but we're not stopping there."?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@le717 Nice, I like that wording

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

nethip added a commit that referenced this pull request Mar 4, 2015
@nethip nethip merged commit 1c5ad4a into adobe:master Mar 4, 2015
@nethip
Copy link
Contributor

nethip commented Mar 4, 2015

This not only looks good to but inspiring as well 😄

@peterflynn
Copy link
Member

@nethip I think there was a misunderstanding -- in the thread above we were talking about using a different wording from what's in this PR, so we don't have to update the README every release. So we wanted to wait to merge this until the wording was updated... @coliff can you put up a new PR with the new wording?

@coliff
Copy link
Contributor Author

coliff commented Mar 4, 2015

@peterflynn Sure - are we going with:
'Brackets may have reached version 1, but we're not stopping there.'
Please confirm and I'll open a PR.

@nethip
Copy link
Contributor

nethip commented Mar 4, 2015

@peterflynn @coliff My Bad I don't know why I was under the impression that the suggested wording was already in the PR. I will review the new PR going to be uploaded by @coliff

@redmunds
Copy link
Contributor

redmunds commented Mar 4, 2015

@coliff

are we going with: 'Brackets may have reached version 1, but we're not stopping there.' ?
Please confirm and I'll open a PR

Yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants