fix: prevent useTooltipTrigger from setting tabIndex
#8622
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
property added in 53d8ed2
wasn't able to think of any counter example, but added some tests
devongovett
reviewed
Jul 25, 2025
| }) | ||
| onKeyDown: onPressStart | ||
| }), | ||
| tabIndex: undefined |
There was a problem hiding this comment.
why is the undefined needed here at all?
There was a problem hiding this comment.
the focusableProps here include a tabIndex, which then gets passed into FocusableContext. for the component consuming that context via useFocusable, the props from context (interactionProps) take precedence over the tabIndex determined by excludeFromTabOrder/isDisabled
another potential fix is to have useFocusable's calculated tabIndex take precedence over the props coming from the context, but that may be a riskier change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8556
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: