Skip to content

Conversation

ooii
Copy link

@ooii ooii commented Apr 7, 2025

The sleep timer isn’t paused when the user pauses, and the volume keeps decreasing during pause. These changes restore both volume and sleep timer to their initial values when play resumes.

…after resume and so does the volume. For this, we have created a variable to store the initial volume value
@pwinnski
Copy link

Conceptually, there seem to be competing assumptions here. Either someone sets a sleep timer to one hour because they need to be sure they listen to the audiobook for no more than one hour, and then sleep or whatever. OR someone sets a sleep timer to one hour because they want to listen to exactly one more hour of the book.

If the first, I'd expect the sleep timer to keep running even if the book is paused. If the second, I would not.

Personally, I suspect the first scenario is more likely, more in line with the concept of a sleep timer, and pausing seems likely when someone finds they are more tired than they realized and aren't even going to make it an hour.

@ooii
Copy link
Author

ooii commented May 4, 2025

Hi,
I understand that the way I want it to work is not the way all the users would have. But, for me, sleep timer contains the word "sleep" and, in my opinion, if the user interacts with the app, it means that the sleep process has been interrupted.
Of course, it's also a timer and can be just used as a timer.
Maybe the best way is to have the ability to choose the behavior of the sleep timer, if it should reset or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants