Add chapter duration to chapters table on book page #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the duration to the chapter table on the book page.
|
@advplyr This works as intended on my iPhone 16 Pro (iOS 18.6.2) 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the chapter duration to the chapter table on the book page.
Brief summary
This aims to resolve #1163 by adding chapter duration to the chapters table on the book page.
Which issue is fixed?
Fixes #1163.
Pull Request Type
This changes the front-end of the android and iOS app.
In-depth Description
It just adds the duration to the ChaptersTable view, the same way it's done on the web page.
How have you tested this?
I tested this in Android Studio, on 2 different size emulated screens.
Screenshots
Original table
pixel5:
small phone:
Table with Duration
pixel5:
small phone: