Skip to content

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Sep 2, 2025

Minor breaking changes that have been resolved:

  • Kubernetes client now has an Apply method. As we are not making use
    of it, and the method signature of it is quite different from the
    other ones. I left it as "unimplemented" (with an error).
  • Minor breaking change in the controller-runtime client, which now
    strips the GVK information from the object. Instead, it has to be
    retrieved explictly. This only affects the credentials endpoint, as
    the other endpoints make use of Unstructured objects (that have their
    GVK defined).

@hiddeco hiddeco added this to the v1.8.0 milestone Sep 2, 2025
@hiddeco hiddeco self-assigned this Sep 2, 2025
@hiddeco hiddeco requested a review from a team as a code owner September 2, 2025 14:06
@hiddeco hiddeco added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 2, 2025
Copy link

netlify bot commented Sep 2, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 193fc70
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/68bf29d1fcbdcb0008540e29
😎 Deploy Preview https://deploy-preview-4973.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.62%. Comparing base (bb407e1) to head (193fc70).

Files with missing lines Patch % Lines
internal/server/get_credentials_v1alpha1.go 50.00% 5 Missing and 1 partial ⚠️
internal/server/kubernetes/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4973      +/-   ##
==========================================
- Coverage   54.62%   54.62%   -0.01%     
==========================================
  Files         401      401              
  Lines       34921    34936      +15     
==========================================
+ Hits        19077    19084       +7     
- Misses      14883    14890       +7     
- Partials      961      962       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- code.gitea.io/sdk/gitea to v0.22.0
- github.com/aws/aws-sdk-go-v2 to v1.38.3
- github.com/aws/aws-sdk-go-v2/config to v1.31.6
- github.com/aws/aws-sdk-go-v2/credentials to v1.18.10
- github.com/aws/aws-sdk-go-v2/service/ecr to v1.50.1
- github.com/aws/aws-sdk-go-v2/service/sts to v1.38.2
- github.com/fluxcd/pkg/kustomize to v1.20.0
- github.com/jferrl/go-githubauth to v1.4.0
- github.com/spf13/cobra to v1.10.1
- github.com/spf13/pflag to v1.0.9
- gitlab.com/gitlab-org/api/client-go to v0.142.5
- google.golang.org/api to v0.248.0
- google.golang.org/grpc to v1.75.0
- k8s.io/cli-runtime to v0.34.0
- sigs.k8s.io/controller-runtime to v0.22.0

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Taylor Thomas <taylor.thomas@akuity.io>
- Kubernetes client now has an `Apply` method. As we are not making use
  of it, and the method signature of it is quite different from the
  other ones. I left it as "unimplemented" (with an error).
- Minor breaking change in the controller-runtime client, which now
  strips the GVK information from the object. Instead, it has to be
  retrieved explictly. This only affects the credentials endpoint, as
  the other endpoints make use of Unstructured objects (that have their
  GVK defined).

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants