Reduce build steps on Linux; bug fixes #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… build products into the correct directories at the correct time. Fix issues with missing water and burnin textures.
… name indexes having a type of char (signed 8 bit), so when the index was higher than 127, and added to a base string index value, it ended up *subtracting* from the base string index leading to bad string indices. Changed the array type to byte (uint8_t, unsigned char)
…/jump jets section of a mech's info display to display crap. This is because if a mech does not have one of those things installed, the value corresponding to that thing is supposed to be 255. The code grabbed the value as a signed char which made its value -1, then compared the -1 to 255 to see if the item was installed. If not installed, it is supposed to not print the line corresponding to the item. But since the compare always failed, it would always try and print something, which was always wrong
|
Hello, Ian. Sorry for a long delay, I do not have a lot of free time due to the situation in our country. If you could split changes to e.g.: code fixes, CMake changs, minor stuff, etc. and resolve the code it would save me time to review and merge it (I pushed some changes some time ago, so your PR not has conflicts). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the build system on Linux to reduce the number of steps required to build the software. Note that I do not have a Windows machine so building on Windows is not tested and with the addition of a sh script, will definitely not work on Windows. Reworked the README.md to reflect the new process.
Fix signed/unsigned issues that caused problems with invalid string indexes being used for components in the mech's info section on the game screen.
Fixed issue that was causing missing assets being referenced.
Fixed issue that was causing mechs and vehicles being rendered twice through 2 render paths, both of which were being run.