Skip to content

[ui/core] GroupAttributes connection #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: dev/connectGroupAttrs
Choose a base branch
from

Conversation

nicolas-lambert-tc
Copy link
Contributor

@nicolas-lambert-tc nicolas-lambert-tc commented Jun 23, 2025

Description

This PR add the possibility to connect GroupAttribute based on this PR (From @cbentejac)

It adds:

  • Connection on Group

Screenshot_2025-07-01_09-41-57
image

  • GroupAttributes can be folded even if connected
    Screenshot_2025-06-18_16-46-38

GroupAttribute connection link the subAttributes:
Screenshot_2025-07-01_09-36-58

Features list

  • Allow GroupAttribute connection
  • Connecting a GroupAttribute connect automatically all subAttributes
  • Disconnecting a subAttribute automatically disconnect the parnt GroupAttribute
  • Connection is handled in ui.graph, so undo are correctly handled
  • Add a function to check the attributes compatibility

Implementation remarks

@nicolas-lambert-tc nicolas-lambert-tc added feature new feature (proposed as PR or issue planned by dev) UI labels Jun 23, 2025
@nicolas-lambert-tc nicolas-lambert-tc changed the base branch from dev/groupAttribute-connections to dev/connectGroupAttrs June 23, 2025 16:06
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 90.71038% with 17 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (7c66c56) to head (8d316bf).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/attribute.py 82.75% 15 Missing ⚠️
meshroom/core/exception.py 75.00% 1 Missing ⚠️
meshroom/core/graph.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           dev/connectGroupAttrs    #2754      +/-   ##
=========================================================
+ Coverage                  78.94%   79.27%   +0.33%     
=========================================================
  Files                         50       53       +3     
  Lines                       6662     6829     +167     
=========================================================
+ Hits                        5259     5414     +155     
- Misses                      1403     1415      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicolas-lambert-tc nicolas-lambert-tc force-pushed the dev/connectAttrs-and-avoid-cycle branch from 47deef3 to 8d316bf Compare June 30, 2025 15:48
@nicolas-lambert-tc nicolas-lambert-tc self-assigned this Jul 1, 2025
@nicolas-lambert-tc nicolas-lambert-tc changed the title Dev/connect attrs and avoid cycle [ui/core] GroupAttributes connection Jul 1, 2025
@nicolas-lambert-tc nicolas-lambert-tc marked this pull request as ready for review July 1, 2025 09:10
@fabiencastan fabiencastan added this to the Meshroom 2025.x milestone Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature (proposed as PR or issue planned by dev) UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants