✨Configure unit conversions via IQuantityInfo #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `IQuantityInfo.RegisterUnitConversions` callback to configure unit conversions - Change `UnitConverter` to configure unit conversions from a list of `IQuantityInfo` - Change `UnitsNetSetup` to pass the default quantity infos into its default `UnitConverter` - Add sample conversions for `HowMuch`
|
Maybe you already have done something like this in your dragon PR, but while reviewing it seemed natural to add something like this. |
angularsen
commented
Jul 25, 2025
| { | ||
| var registerMethod = quantity.QuantityType.GetMethod(nameof(Length.RegisterDefaultConversions), BindingFlags.NonPublic | BindingFlags.Static); | ||
| registerMethod?.Invoke(null, new object[]{unitConverter}); |
There was a problem hiding this comment.
Good riddance to this reflection stuff
|
Yes, these are already covered by introducing the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
======================================
Coverage 93% 93%
======================================
Files 311 311
Lines 28781 28780 -1
======================================
Hits 26864 26864
+ Misses 1917 1916 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IQuantityInfo.RegisterUnitConversionscallback to configure unit conversionsUnitConverterto configure unit conversions from a list ofIQuantityInfoUnitsNetSetupto pass the default quantity infos into its defaultUnitConverterHowMuch