add hook for day rollover #3817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeprobst
force-pushed
the
rollover_hook
branch
2 times, most recently
from
633988c to
f89de4b
Compare
|
The hook seems useful, my only request is that you follow the naming convention (e.g day_did_change) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking in anki to see how day rollover is managed so I can run code around when it triggers for an addon I am working on and saw that it was trivial to add a hook for it! I get that I can hook the
main_window_did_initand then duplicate this logic in my addon, but this seems like a nice thing to have a hook for.The use case for me is for it to be used in conjunction with cases I'd hook
profile_did_openfor, but to also handle cases where I left anki on overnight and would like the logic to still run without having to close and reopen anki.My feelings on this aren't particuarly strong so feel free to close this PR if this is not desired.