Add title for some dialogs and avoid hardcoding the text of the discard changes dialog

[BrayanDSO]

Similar to #3838.

The commits should be self-explanatory

[BrayanDSO]

https://buildkite.com/ankitects/anki-ci/builds/9828#019570d0-4c81-4d5c-84cb-c0fd6bd0bb19/52-265

the CONTRIBUTORS script is really broken. Do I need to change it in EVERY PR I do?

[BrayanDSO]

apparently the only way to retrigger CI here is doing a push force, and the odd error still persists. Not sure if I can do anything now

[dae]

Each of the changes you've made to that file have been listed as your capitalized noreply username:

dae@mb:Work/desktop/anki% git log --pretty=format:%ae -- CONTRIBUTORS | grep -i brayan
69634269+BrayanDSO[rest redacted]
69634269+BrayanDSO
69634269+BrayanDSO

The last check failed because your username for the latest commit was 69634269+brayandso@. How did you author and push the commits? What do you have your git author email configured as?

[BrayanDSO]

Under my branch:

git show HEAD

commit 7eb2d3c (HEAD -> more-dialogs, dso/more-dialogs)
Author: Brayan Oliveira 69634269+brayandso@users.noreply.github.com
Date: Fri Mar 7 10:32:15 2025 -0300

add name to about screen

git config user.name
Brayan Oliveira
git config user.email
69634269+brayandso@users.noreply.github.com

Looks alright to me

[dae]

That's lowercase, whereas your GitHub username is mixed case. Email addresses are theoretically case-sensitive: https://stackoverflow.com/questions/9807909/are-email-addresses-case-sensitive. I don't recall any other users hitting this so far, but happy to accept a PR that makes the check in minilints case-insensitive.

[BrayanDSO]

For checking the GitHub account, only the ID should matter. The username shouldn't.

[dae]

This is a check of the git commit history, and commits can be made outside of GitHub / with non-GitHub accounts in some cases (when PRs are not squashed, commits are cherry-picked outside GitHub, etc). It's not a GitHub-specific check.