Skip to content

add ellipsis to Grade Now #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

Conversation

L-M-Sherlock
Copy link
Contributor

The context menu entry should display “Grade Now …” (with ellipsis). Ellipsis (three dots) are typically added programmatically to strings requiring additional user input before action execution. Other context menu options around “Grade Now” include ellipsis, so this should align for consistency.

source: https://forums.ankiweb.net/t/anki-25-05-beta/59710/37?u=l.m.sherlock

@dae
Copy link
Member

dae commented Apr 29, 2025

I propose a different approach. Since we'll presumably want to add these to the mobile clients in the future, I suggest the translation be moved into the rslib rtl and left without the dots (since mobile clients don't use dots). For the desktop, you can then make use of add_ellipsis_to_action_label()

@dae
Copy link
Member

dae commented Apr 29, 2025

Sorry, should have read the patch more carefully ^_^; Suggest just the latter part, since we already have it in rslib's actions.ftl.

@L-M-Sherlock
Copy link
Contributor Author

I feel confused when I search add_ellipsis_to_action_label because only two actions used it.

@dae
Copy link
Member

dae commented Apr 29, 2025

Pre-Rust, all of our translations had ...s on them. Since we transitioned to Rust, for newer labels, I've been trying to put them in actions + make use of that routine so we can reuse them across the clients.

@dae dae merged commit 92cfb73 into ankitects:main Apr 29, 2025
1 check passed
@L-M-Sherlock L-M-Sherlock deleted the add-ellipsis-to-Grade-Now branch April 29, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants