Fix repeated ticks in reviews graph #4108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regressed in ankitects#4086
|
These things happen. Appreciate the follow-up fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4086, I tried to make the ticks looks cleaner because ticks like 16.67m, 33.33m, 1.11h, 1.39h, etc. look unclean.
However, this resulted in a regression. In 25.06b4, the graph looks like this. Note the repeated 1h and 2h ticks.
This PR fixes that regression by setting precise=True again. I think we need a better way to control the rounding precision (https://forums.ankiweb.net/t/reduce-precision-of-time-studied-today/42309). But, that's out of scope of this PR.